Danil Chapovalov
b0fe794d7d
Delete expired field trial WebRTC-SignalNetworkPreferenceChange
...
Bug: webrtc:42221944
Change-Id: I786d73f5ede27d4ab40a9b3b2fef49da45bd3444
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350302
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42274}
2024-05-11 09:50:40 +00:00
webrtc-version-updater
14426c0ff9
Update WebRTC code version (2024-05-11T04:03:38).
...
Bug: None
Change-Id: I00da0eeec69f005754f01413a6e30fe9fda7f334
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350382
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42273}
2024-05-11 05:30:05 +00:00
chromium-webrtc-autoroll
43dc4e57dd
Roll chromium_revision b42414ce8c..6893822af1 (1299281:1299647)
...
Change log: b42414ce8c..6893822af1b42414ce8c..6893822af1a23b0a1282..eca74b9a11755be2aee3..3df98e11075a26b48913..efc3bab65df997803062..6bf0c6a91ehttps://chromium.googlesource.com/catapult.git/+log/3a1d1cc096..923a565b97
* src/third_party/depot_tools: 6e32e926e9..a9b9284fafhttps://aomedia.googlesource.com/aom.git/+log/5ccdc66ab6..d9ab67e87c
* src/third_party/libc++abi/src: d17298ab09..a37a3aa431a184749b9d..1e12d458b7b42414ce8c..6893822af1https://webrtc-review.googlesource.com/c/src/+/350380
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42272}
2024-05-11 03:28:06 +00:00
chromium-webrtc-autoroll
c9e81edc9e
Roll chromium_revision 1f2c94c46e..b42414ce8c (1299115:1299281)
...
Change log: 1f2c94c46e..b42414ce8c1f2c94c46e..b42414ce8cb2163519a9..01e3c73f58853d3fcffd..755be2aee346a35f0196..5a26b48913e16870de33..f99780306279bd89fb62..a184749b9d1f2c94c46e..b42414ce8chttps://webrtc-review.googlesource.com/c/src/+/350345
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42271}
2024-05-10 16:43:06 +00:00
Danil Chapovalov
ac426265b6
Cleanup usage of FieldTrialsView by RateControlSettings and CongestionWindowPushbackController
...
Replace factory that takes optional FieldTrialView with a constructor that takes non-optional reference to the same interface - all callers already guarantee it is not nullptr
Replace several local IsEnabled/IsDisabled helpers with the same helpers in FieldTrialView
In CongestionWindowPushbackController tests pass field trials bypassing global field trial string
Bug: webrtc:42220378
Change-Id: Ic49ad78919d834a5e3b9b69545d3b39088023a75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349900
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42270}
2024-05-10 12:40:20 +00:00
Danil Chapovalov
58a9f6d490
Delete depercated variant of the Network::GetCost function
...
Bug: webrtc:42220378
Change-Id: Iebfc924ab55896981cbf83407a9b049e4d0dde8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350303
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42269}
2024-05-10 11:25:19 +00:00
Danil Chapovalov
2cdf840b53
Read WebRTC-BweLossExperiment from propagated instead of global field trial
...
Bug: webrtc:42220378
Change-Id: I4ddb0719aabe89997ba4f2e663515c1b227938ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350301
Reviewed-by: Ying Wang <yinwa@google.com>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42268}
2024-05-10 10:05:27 +00:00
Sergey Silkin
dbdf36c437
Add key_interval command line argument to codec test
...
Bug: webrtc:42225151, b/337757868
Change-Id: I5b085bdb334cb6cfb304424a466fc119196d14d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350200
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42267}
2024-05-10 09:40:18 +00:00
chromium-webrtc-autoroll
8b243eae30
Roll chromium_revision fb6772e9b1..1f2c94c46e (1298140:1299115)
...
Change log: fb6772e9b1..1f2c94c46efb6772e9b1..1f2c94c46ece2851f9b9..a23b0a128218c63ed8a3..b2163519a91ed5a9966e..4e0e9c73a0deb2830717..853d3fcffdd247921fd1..46a35f0196bb8ac17606..e16870de33https://chromium.googlesource.com/catapult.git/+log/4a82c77f04..3a1d1cc096
* src/third_party/depot_tools: 2ca8efcec8..6e32e926e92240e21cf5..a46424228f364118a1d9..98f24945182dbc56e416..79bd89fb62fb6772e9b1..1f2c94c46ehttps://webrtc-review.googlesource.com/c/src/+/350341
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42266}
2024-05-10 08:33:28 +00:00
webrtc-version-updater
2c02afbb47
Update WebRTC code version (2024-05-10T04:04:03).
...
Bug: None
Change-Id: Idcf61c4594a16ef3a7cc44f99b665fa879e7e7a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350340
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42265}
2024-05-10 05:41:25 +00:00
chromium-webrtc-autoroll
cc9dcaf4a9
Roll chromium_revision 2d895ae064..fb6772e9b1 (1297992:1298140)
...
Change log: 2d895ae064..fb6772e9b12d895ae064..fb6772e9b138ca195188..ce2851f9b97796c50af5..18c63ed8a39703d9137f..1ed5a9966e5daaa568a5..deb2830717609ad676f2..d247921fd139ab37d586..bb8ac17606https://chromium.googlesource.com/catapult.git/+log/47d3198a95..4a82c77f04
* src/third_party/r8: ntlyos9oLHW_q1AeZovqFuTYzog9dKd2lITTowptHuYC..TMzYxnQF_ASgPEXkE1DM272ROaHqDBQMjhmdIllz7uUC
* src/tools: 98f970e378..2dbc56e4162d895ae064..fb6772e9b1https://webrtc-review.googlesource.com/c/src/+/350261
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42264}
2024-05-08 16:55:19 +00:00
Per K
53d43d6a41
SimulatedNetworkNode::Builder use BuiltInNetworkBehaviorConfig.link_capacity
...
Bug: webrtc:14525
Change-Id: I0495e26244334a5bdb015912fbdaa7af7f2aefea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350280
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42263}
2024-05-08 16:28:40 +00:00
Harald Alvestrand
f42d2b9ab5
Include-what-you-use pc/media_session
...
Bug: webrtc:42226242
Change-Id: I25743717d1f0e7a0305589139bd386353b4e5054
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350122
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42262}
2024-05-08 15:07:53 +00:00
Sergey Sukhanov
26a082ce36
Introduce a mode that lets NetworkEmulationManager ignore DTLS handshake sizes.
...
Bug: b/169531206
Change-Id: I02c19385ff7078944f7509ecc07358b4315f7b08
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350181
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42261}
2024-05-08 13:20:20 +00:00
Danil Chapovalov
f20ed3e8ad
Add option to provide Environment for CongestionConroller construction
...
This would allow network controllers, GoogCcNetworkController in particular to have access to Environment at construction and thus it can rely on propagated field trials and won't need to fallback to the global field trial string
Bug: webrtc:42220378
Change-Id: I36099522e3866a89a8c8d6303da03f7d5b1cad8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350201
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42260}
2024-05-08 12:46:23 +00:00
Sergey Silkin
5f3fc5028f
Split CreateEncodingSettings
...
into CreateEncodingSettings and CreateFrameSettings. Also changed bitrate/framerate data types from int/double to DataRate/Frequency.
Bug: webrtc:42225151, b/337757868
Change-Id: I01b8b4e3d34f72250fdb8d64e4ee98ff79bbbd8b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349962
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42259}
2024-05-08 11:07:39 +00:00
Christoffer Dewerin
35af7ccfb0
Move sharding logic to the correct context
...
Bug: b:338087169
Change-Id: I380f03c34ffcee315ef5084263f9f740b6bc4176
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349642
Commit-Queue: Christoffer Dewerin <jansson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42258}
2024-05-08 10:15:10 +00:00
chromium-webrtc-autoroll
1545cdc76b
Roll chromium_revision 67ad773ea4..2d895ae064 (1297526:1297992)
...
Change log: 67ad773ea4..2d895ae06467ad773ea4..2d895ae0643fb05bdb07..38ca195188230ed1b9ae..7796c50af505a5c9ceb2..5daaa568a5eda5540f8f..609ad676f24a4d80f78d..39ab37d586https://chromium.googlesource.com/catapult.git/+log/4cc26001b9..47d3198a95
* src/third_party/depot_tools: c9fb389f4b..2ca8efcec82d684efe87..fa6de7f4389905cc8b11..98f970e37867ad773ea4..2d895ae064https://webrtc-review.googlesource.com/c/src/+/350148
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42257}
2024-05-08 08:56:15 +00:00
Guy Hershenbaum
94dfe1cc59
Fix NetworkMonitor race condition when dispatching native observers
...
There is a race condition in NetworkMonitor where native observers may be removed concurrently with a notification being dispatched, leading to a dangling pointer dereference (trying to dispatch an observer that was already removed and destroyed), and from there a crash with access violation.
By ensuring dispatching to native observers is done within the synchronization lock that guards additions/removals of native observers protects against this race condition.
Since native observers callbacks are posted to the networking thread in the C++ side anyway, there should be no risk of deadlock/starvation due to long-running observers.
Bug: webrtc:15837
Change-Id: Id2b788f102dbd25de76ceed434c4cd68aa9a569e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338643
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42256}
2024-05-08 08:27:19 +00:00
Mirko Bonadei
fc57037462
Revert "Split digest methods from ssl target into digest target"
...
This reverts commit 47bfe39ecfhttps://webrtc-review.googlesource.com/c/src/+/349764
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Philipp Hancke <phancke@meta.com>
> Cr-Commit-Position: refs/heads/main@{#42249}
Bug: None
Change-Id: Ice6f901cd8c2aecf4cf44d3728ec76568b19a7ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350180
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42255}
2024-05-08 06:42:32 +00:00
webrtc-version-updater
8de2cf7c93
Update WebRTC code version (2024-05-08T04:01:40).
...
Bug: None
Change-Id: I4635d184e8a3ebdf83b956076c17232e761115b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350163
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42254}
2024-05-08 05:48:56 +00:00
Per K
0d037df25f
Reland "Add more accurate support for changing capacity in SimulatedNetwork"
...
Origina description:
NetworkBehaviorInterface::RegisterDeliveryTimeChangedCallback
adds support for a network behaviour to reschedule next time DequeueDeliverablePackets should be invoked.
SimulatedNetwork::SetConfig(const BuiltInNetworkBehaviorConfig& config,
Timestamp config_update_time)
adds possibility to change the configuration at config_update_time. Delivery time of a packet currently in the narrow section, will depend on the link capacity before and after the update.
Bug: webrtc:14525
Change-Id: Idaf3a4200cfeae0683e1e1d1e98e154119ddf22e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350043
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42253}
2024-05-07 20:14:24 +00:00
Per K
cc92b6e1bd
Add ProbeController::EnableRepeatedInitialProbing
...
This adds a new mode to the ProbeController that sends probes every
second the first 5seconds. Intented usage is before normal media has
started flowing. If enabled, the max allocated bitrat is ignored during
these initial probes.
The purpose is to have a more accurate estimate at the beginning of a
call.
The cl also removes ProbeController::SetFirstProbeToMaxBitrate.
Bug: webrtc:14928
Change-Id: I04feefb2f1b82ff38b35ee2be810f9119c53536a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349924
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42252}
2024-05-07 19:37:23 +00:00
chromium-webrtc-autoroll
ae8cf2bc0b
Roll chromium_revision 2c3468559e..67ad773ea4 (1297387:1297526)
...
Change log: 2c3468559e..67ad773ea42c3468559e..67ad773ea4d8a00a3b74..3fb05bdb0739e82ca2f8..230ed1b9ae28b4e69990..05a5c9ceb22e34c023ba..eda5540f8f2f108b7164..4a4d80f78d9c90438ae1..9905cc8b112c3468559e..67ad773ea4https://webrtc-review.googlesource.com/c/src/+/350141
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42251}
2024-05-07 17:18:47 +00:00
Sergey Silkin
f126e8af82
Delete implicit layering mode.
...
This is a cleanup in VP9 encoder wrapper. The removed code paths were only used in tests. In prod layers are configured explicitly via VideoCodec::spatialLayers[].
Bug: webrtc:42225151
Change-Id: I1de90039488b36e3c88e788c78e675bf2ee68f9b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349222
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42250}
2024-05-07 16:59:06 +00:00
Philipp Hancke
47bfe39ecf
Split digest methods from ssl target into digest target
...
in an attempt to break up the monolithic ssl target.
BUG=None
Change-Id: I38f5b3e2828742d5d918460db1af0a5797d6a5c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349764
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42249}
2024-05-07 16:52:48 +00:00
Per K
25618716f6
Make perkj owner of call/
...
Bug: none
Change-Id: I6ecf87009b38b26cb37193c2c1dc3e40b1786236
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350100
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42248}
2024-05-07 15:13:29 +00:00
Harald Alvestrand
141f4c153f
Provide mechanism to make codec decisions per-transceiver
...
This provides a way to tell the SDP generator to use a specific list
of codecs, rather than trying to compute what list to send.
Preparatory to making codec decisions per-transceiver.
Bug: webrtc:42226302
Change-Id: I1b7d4e55ed7a0546394b74820b4e51434ef86ad9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349620
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tony Herre <herre@google.com>
Cr-Commit-Position: refs/heads/main@{#42247}
2024-05-07 14:32:18 +00:00
chromium-webrtc-autoroll
30e3553229
Roll chromium_revision 5faeabaa35..2c3468559e (1297280:1297387)
...
Change log: 5faeabaa35..2c3468559e5faeabaa35..2c3468559ed0d20a0310..d8a00a3b749bbd397adb..28b4e6999014c112dabf..2e34c023ba74e83ce399..2f108b71644d9ad255f1..c9fb389f4b55e645b5b0..9c90438ae15faeabaa35..2c3468559ehttps://webrtc-review.googlesource.com/c/src/+/350060
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42246}
2024-05-07 11:46:40 +00:00
Per Kjellander
6866da1822
Revert "Add more accurate support for changing capacity in SimulatedNetwork"
...
This reverts commit 51a70c0d6fhttps://webrtc-review.googlesource.com/c/src/+/349461
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42243}
Bug: webrtc:14525
Change-Id: Iace13b1b4ef21005c9668ff27f6d1ec8f3212baf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349923
Owners-Override: Per Kjellander <perkj@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42245}
2024-05-07 11:02:33 +00:00
Björn Terelius
fba7d846ca
Refactor event log analyser bindings unit test
...
Bug: None
Change-Id: If343333a46b9cdd8c8df8753ceddca3a14a98cf8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350040
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42244}
2024-05-07 09:36:13 +00:00
Per K
51a70c0d6f
Add more accurate support for changing capacity in SimulatedNetwork
...
NetworkBehaviorInterface::RegisterDeliveryTimeChangedCallback
adds support for a network behaviour to reschedule next time DequeueDeliverablePackets should be invoked.
SimulatedNetwork::SetConfig(const BuiltInNetworkBehaviorConfig& config,
Timestamp config_update_time)
adds possibility to change the configuration at config_update_time. Delivery time of a packet currently in the narrow section, will depend on the link capacity before and after the update.
Bug: webrtc:14525
Change-Id: I271251992d05c68f9160bb81811ea8f2efe9c921
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349461
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42243}
2024-05-07 08:53:16 +00:00
Danil Chapovalov
2ee83c1784
Provide Environment for ReceiveSideConfestionController construction
...
Environment includes propagated field trials that can be later passed to
RemoteBitrateEstimators member, and would allow not to rely on the global field trial string
Bug: webrtc:42220378
Change-Id: Icf75a433c20352b2c22829c2148c92f69a2517aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349645
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42242}
2024-05-07 08:02:36 +00:00
Sergey Silkin
f5e9f11994
Delete WebRTC-LibaomAv1Encoder-DisableFrameDropping
...
This was a kill-switch for frame dropping in AV1 encoder. The frame dropping was enabled in June 2023. Since we have not heard about about any issues related to the frame dropping, we can remove the field trial.
Bug: webrtc:42225542
Change-Id: I4b2f1d5ff61e4ae3a4a7fc6711bb83f7d522fc6a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349921
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42241}
2024-05-07 07:47:32 +00:00
webrtc-version-updater
da648b5960
Update WebRTC code version (2024-05-07T04:06:18).
...
Bug: None
Change-Id: I0eee5f0e57ba2d26ee5642fbb6337dc5c30d3a94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349982
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42240}
2024-05-07 05:45:40 +00:00
chromium-webrtc-autoroll
94f1d9f127
Roll chromium_revision d2acc67c32..5faeabaa35 (1297067:1297280)
...
Change log: d2acc67c32..5faeabaa35d2acc67c32..5faeabaa35a199be8d05..d0d20a031051d50e330a..39e82ca2f85a2d9b6943..9bbd397adb85ed157cb6..14c112dabfdb2852e97e..74e83ce39994f42f8fe3..4d9ad255f1d0e3239f32..2240e21cf52d16ed055d..2d684efe87b61b272208..108f5128e2fa9a22c136..55e645b5b0d2acc67c32..5faeabaa35https://webrtc-review.googlesource.com/c/src/+/349981
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42239}
2024-05-07 04:55:19 +00:00
chromium-webrtc-autoroll
84e90556aa
Roll chromium_revision 7f4bb5d096..d2acc67c32 (1296883:1297067)
...
Change log: 7f4bb5d096..d2acc67c327f4bb5d096..d2acc67c3282b79263b2..a199be8d054a7a95bb98..5a2d9b69436d4eb9fa87..85ed157cb6cf914a1d98..db2852e97e7bd887f177..d0e3239f3239a399c253..fa9a22c1367f4bb5d096..d2acc67c32https://webrtc-review.googlesource.com/c/src/+/349825
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42238}
2024-05-06 21:01:03 +00:00
Philipp Hancke
3f10f65713
sdp: answer with spec msid when msid support is unknown
...
this removes the reliance on the no-longer-spec a=msid-semantic lines
in case the offer did not signal any msid. Endpoints not supporting
msid should silently ignore the resulting a=msid: line. This also changes behavior such that a "legacy" offer without msid-semantic
line will be responded to with both msid-semantic and msid for any tracks present.
Plan-B ssrc-specific msid attributes are not signalled in that case.
See https://datatracker.ietf.org/doc/html/rfc8829#section-5.3.1
which includes it in the answer depending on the transceiver direction
but not if and only if the offer signalled a msid.
This also avoids recreating the stream and changing the SSRC
which could happen if the answer object was serialized to SDP
(which most unit tests do not do)
BUG=chromium:328522463
Change-Id: Id2f890b7756721d7c50460359950826d392483ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346741
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#42237}
2024-05-06 19:20:48 +00:00
Jakob Ivarsson
1e5f88c5be
Make muted param in GetAudio optional.
...
It is not necessary for the caller to use it and the mute info can be
found on AudioFrame.muted().
Bug: None
Change-Id: I458f1f2e8489c1d8f8a9078b21f889b2540bdab9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349940
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42236}
2024-05-06 18:07:34 +00:00
chromium-webrtc-autoroll
86cd7a35dc
Roll chromium_revision 27cbc72c1a..7f4bb5d096 (1296748:1296883)
...
Change log: 27cbc72c1a..7f4bb5d09627cbc72c1a..7f4bb5d0966d818d2c6c..82b79263b2beb031dae2..51d50e330acf4ffc52d9..4a7a95bb98973b66d6ca..6d4eb9fa87c6e9e7ee9e..cf914a1d98a60f90e38e..94f42f8fe309737b8e11..d17298ab091ead5ebcea..39a399c25327cbc72c1a..7f4bb5d096https://webrtc-review.googlesource.com/c/src/+/349824
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42235}
2024-05-06 16:53:56 +00:00
Philipp Hancke
89679bfd02
sdp: document existing mid backfill cornercases
...
mids get backfilled starting with 0 which means they are always
present in the answer (even though JSEP says otherwise) and may
even be backfilled in a manner compatible with their usage in a
BUNDLE group. Those cases are ok-ish but should be documented by
tests.
BUG=None
Change-Id: I69f0475c279da5022109a56f0006169dbc2de147
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349380
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42234}
2024-05-06 16:38:37 +00:00
Danil Chapovalov
01ff41e594
Cleanup expired field trial WebRTC-Avx2SupportKillSwitch
...
Bug: webrtc:42221774
Change-Id: I92fab7d14fd0c2a9fd10e91fbad9c2831d7415ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349643
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42233}
2024-05-06 14:33:21 +00:00
chromium-webrtc-autoroll
9559b2da36
Roll chromium_revision d6f2f1ce6b..27cbc72c1a (1296010:1296748)
...
Change log: d6f2f1ce6b..27cbc72c1ad6f2f1ce6b..27cbc72c1a19d62484ea..6d818d2c6cce8359ec57..beb031dae253137cc40f..cf4ffc52d947f4e44806..973b66d6ca81e66a1a83..c6e9e7ee9ehttps://chromium.googlesource.com/catapult.git/+log/0421a22c02..4cc26001b9
* src/third_party/depot_tools: 39c8c75cf6..a60f90e38e13d1180f45..7bd887f1772954cb8d87..2d16ed055dhttps://aomedia.googlesource.com/aom.git/+log/ae7e8cc435..5ccdc66ab6
* src/third_party/libc++abi/src: 51fe358446..09737b8e110d315e6aaf..1ead5ebcead6f2f1ce6b..27cbc72c1ahttps://webrtc-review.googlesource.com/c/src/+/349697
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42232}
2024-05-06 11:56:48 +00:00
Mirko Bonadei
549c413ed7
Roll chromium_revision 669d8ffcd7..d6f2f1ce6b (1292426:1296010)
...
Change log: 669d8ffcd7..d6f2f1ce6b669d8ffcd7..d6f2f1ce6bb9a86f600d..19d62484ea3be1f2e6bb..ce8359ec57571c37f17d..9703d9137f4873438ace..53137cc40f03850de4bf..47f4e44806ffa3f1738b..81e66a1a83https://boringssl.googlesource.com/boringssl.git/+log/f94f3ed396..2db0eb3f96
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d980d879d2..0421a22c02
* src/third_party/depot_tools: fb94001f06..39c8c75cf6e2bcca40ca..13d1180f455a37b517ad..2954cb8d87https://aomedia.googlesource.com/aom.git/+log/a4420e55a8..ae7e8cc435
* src/third_party/libvpx/source/libvpx: 85dafa9c61..b61b272208234fd02711..6aaa8a1fb1b84e3ff189..2b354c6ad0736f7f77cd..0d315e6aaf669d8ffcd7..d6f2f1ce6b669d8ffcd7..d6f2f1ce6bhttps://webrtc-review.googlesource.com/c/src/+/349760
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42231}
2024-05-06 08:52:37 +00:00
Jeremy Leconte
5dbc4a45bc
Temporary disable sharding on Fuchsia bots.
...
Change-Id: I248ef19317de9a93751641e8bf0cab80a42a35f7
Bug: b/338087169
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349840
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42230}
2024-05-06 07:45:58 +00:00
webrtc-version-updater
53156f0821
Update WebRTC code version (2024-05-06T04:02:48).
...
Bug: None
Change-Id: I9dddec60b52cdc65c2821ed31fa26fbc9001271f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349822
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42229}
2024-05-06 05:21:02 +00:00
webrtc-version-updater
a2e33ed880
Update WebRTC code version (2024-05-05T04:01:32).
...
Bug: None
Change-Id: Iaf10dabc91847cf59c5cdebc72f05a7bb8baa979
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349772
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42228}
2024-05-05 05:28:50 +00:00
webrtc-version-updater
00670e782e
Update WebRTC code version (2024-05-04T04:05:48).
...
Bug: None
Change-Id: Icf34a9beef05cbf83125b773200b5c813f92676b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349768
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#42227}
2024-05-04 05:32:18 +00:00
Sergey Silkin
853e247fbb
Set full path to input video in EncodeDecode test
...
Replaced --video_name with --input_path, --input_width, --input_height and --input_framerate_fps.
Example of command line:
video_codec_perf_tests --input_width=1920 --input_height=1080 --input_framerate_fps=30 --input_path="/full/path/sample.yuv"
Also added y4m source support to the codec tester.
Bug: b/42225151, b/337757868
Change-Id: Ic399b3e819a126e097072c27d74a5fcc0dc1fe6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349581
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42226}
2024-05-03 17:46:05 +00:00
Danil Chapovalov
8b7d89a85f
Cleanup expired field trial WebRTC-Video-QualityRampupSettings
...
Bug: webrtc:42221607
Change-Id: I72f271a2063ed543cd45b771991ce73208ed45c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349721
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42225}
2024-05-03 15:04:51 +00:00
