Commit graph

4 commits

Author SHA1 Message Date
Emil Lundmark
61deb0be81 Reset global state before testing FieldTrials
Calling InitFieldTrialsFromString modifies a global variable so we must
make sure that state is reset between test runs.

Bug: webrtc:10335, webrtc:14336
Change-Id: Ia9839dd16a330ed3220ed470c28c541fc1cc0678
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271022
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37731}
2022-08-10 07:55:46 +00:00
Emil Lundmark
5fbe42a0b3 Clean up FieldTrials unit tests
This renames the tests to also capture the expected outcome of the test
along with some minor code cleanups. Some tests have also been added or
extended to tests more invariants.

Bug: None
Change-Id: I0bc733026118eb90646929b164bfc148665556a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267169
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Auto-Submit: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37673}
2022-08-03 10:05:44 +00:00
Jonas Oreland
f096e74157 WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 18/inf
This cl/ creates a constructor for a FieldTrials object that is
not backed by the global string. Use with care!

Bug: webrtc:10335
Change-Id: I8c48d1e8bb52fef78524d890cc90473355be617f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264461
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37057}
2022-05-31 10:50:58 +00:00
Jonas Oreland
128c4dcbea WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 13/inf
Create FieldTrials class for setting the field trials from a string
in a program. We can later e.g add a builder class where one
can add key/value pairs.

This class is supposed to replace
webrtc::field_trial::InitFieldTrialsFromString.

No-Try: True
Bug: webrtc:10335
Change-Id: I17f45e401102fddda50ca7c4a04bea2f1cb87788
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256973
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36376}
2022-03-30 10:57:49 +00:00