webrtc/modules
Anton Sukhanov 1a13c8f11a Add option to remove transport sequence number from FEC packet calculation
This is experimental field trial to exclude transport sequence number from FEC packets and should only be used in conjunction with datagram transport. Datagram transport removes transport sequence numbers from RTP packets and uses datagram feedback loop to re-generate RTCP feedback packets, but FEC contorol packets are calculated before sequence number is removed and as a result recovered packets will be corrupt unless we also remove transport sequence number during FEC calculations.

This change is a bit embarrassing, but it was the easiest workaround we found to make FEC work with datagrams. Added TODO to find better long term solution.

TODO(sukhanov): We need to find find better way to implement FEC with datagram transport, probably moving FEC to datagram integration layter. Wealso remove special field trial once we switch datagram path from RTCConfiguration flags to field trial and use the same field trial for FECworkaround.

Bug: webrtc:9719
Change-Id: I1e23c56e3cbaa087460410942fb6c5b4921a763e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146221
Commit-Queue: Anton Sukhanov <sukhanov@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28686}
2019-07-25 22:47:27 +00:00
..
audio_coding Switch neteq_rtpplay into an executable. 2019-07-25 08:45:21 +00:00
audio_device [Cleanup] Remove write-only member _sndCardRecDelay. 2019-07-22 14:26:28 +00:00
audio_mixer Reland "Reland "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker."" 2019-07-24 16:47:13 +00:00
audio_processing Migrate WebRTC test infra to ABSL_FLAG. 2019-07-19 06:54:04 +00:00
bitrate_controller Format almost everything. 2019-07-08 13:45:15 +00:00
congestion_controller Report congestion window updates on GoogCC time updates 2019-07-24 14:49:59 +00:00
desktop_capture Use PW_RENDERFULLCONTENT to capture occluded windows on Win8.1 and Win10 2019-07-15 18:58:26 +00:00
include Format almost everything. 2019-07-08 13:45:15 +00:00
pacing New pacer: make FlexFEC and Video priority equal 2019-07-25 08:58:31 +00:00
remote_bitrate_estimator Adds improved estimate bounded backoff to AimdRateControl. 2019-07-22 12:22:09 +00:00
rtp_rtcp Add option to remove transport sequence number from FEC packet calculation 2019-07-25 22:47:27 +00:00
third_party Format almost everything. 2019-07-08 13:45:15 +00:00
utility Format almost everything. 2019-07-08 13:45:15 +00:00
video_capture Format almost everything. 2019-07-08 13:45:15 +00:00
video_coding Don't assume all simulcast screenshare have 2 temporal layers 2019-07-18 11:51:03 +00:00
video_processing Format almost everything. 2019-07-08 13:45:15 +00:00
BUILD.gn Get rid of deprecated version of NackSender::SendNack [2/2] 2019-06-28 17:58:38 +00:00
module_common_types_unittest.cc [Cleanup] Add missing #include. Remove useless ones. IWYU part 2. 2018-11-28 18:25:07 +00:00
OWNERS