webrtc/modules/rtp_rtcp
Anton Sukhanov 1a13c8f11a Add option to remove transport sequence number from FEC packet calculation
This is experimental field trial to exclude transport sequence number from FEC packets and should only be used in conjunction with datagram transport. Datagram transport removes transport sequence numbers from RTP packets and uses datagram feedback loop to re-generate RTCP feedback packets, but FEC contorol packets are calculated before sequence number is removed and as a result recovered packets will be corrupt unless we also remove transport sequence number during FEC calculations.

This change is a bit embarrassing, but it was the easiest workaround we found to make FEC work with datagrams. Added TODO to find better long term solution.

TODO(sukhanov): We need to find find better way to implement FEC with datagram transport, probably moving FEC to datagram integration layter. Wealso remove special field trial once we switch datagram path from RTCConfiguration flags to field trial and use the same field trial for FECworkaround.

Bug: webrtc:9719
Change-Id: I1e23c56e3cbaa087460410942fb6c5b4921a763e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146221
Commit-Queue: Anton Sukhanov <sukhanov@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28686}
2019-07-25 22:47:27 +00:00
..
include Optimize sending the MID and (R)RID header extensions 2019-07-25 19:23:14 +00:00
mocks Adds remote estimate RTCP packet. 2019-07-24 10:17:26 +00:00
source Add option to remove transport sequence number from FEC packet calculation 2019-07-25 22:47:27 +00:00
test/testFec Revert "Refactor FEC code to use COW buffers" 2019-07-11 19:55:28 +00:00
BUILD.gn Move RtpPacketSender and merge it with RtpPacketPacer. 2019-07-24 13:28:21 +00:00
DEPS Replace field trials with WebRtcKeyValueConfig in RtpRtcpModule 2019-02-21 14:25:34 +00:00
OWNERS Add sprang@ as owner in modules/rtp_rtcp 2019-07-24 17:06:36 +00:00