mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-20 09:07:52 +01:00
c89fdd716c
PlatformThread's API is using old style function pointers, causes casting, is unintuitive and forces artificial call sequences, and is additionally possible to misuse in release mode. Fix this by an API face lift: 1. The class is turned into a handle, which can be empty. 2. The only way of getting a non-empty PlatformThread is by calling SpawnJoinable or SpawnDetached, clearly conveying the semantics to the code reader. 3. Handles can be Finalized, which works differently for joinable and detached threads: a) Handles for detached threads are simply closed where applicable. b) Joinable threads are joined before handles are closed. 4. The destructor finalizes handles. No explicit call is needed. Fixed: webrtc:12727 Change-Id: Id00a0464edf4fc9e552b6a1fbb5d2e1280e88811 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215075 Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33923} |
||
|---|---|---|
| .. | ||
| android | ||
| dummy | ||
| g3doc | ||
| include | ||
| linux | ||
| mac | ||
| win | ||
| audio_device_buffer.cc | ||
| audio_device_buffer.h | ||
| audio_device_config.h | ||
| audio_device_data_observer.cc | ||
| audio_device_generic.cc | ||
| audio_device_generic.h | ||
| audio_device_impl.cc | ||
| audio_device_impl.h | ||
| audio_device_name.cc | ||
| audio_device_name.h | ||
| audio_device_unittest.cc | ||
| BUILD.gn | ||
| DEPS | ||
| fine_audio_buffer.cc | ||
| fine_audio_buffer.h | ||
| fine_audio_buffer_unittest.cc | ||
| mock_audio_device_buffer.h | ||
| OWNERS | ||