mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
28b793b4dd
As of [1], a single VP9 encoder instance can produce simulcast 4:2:1.
When it does, the EncodedImage has its simulcast index set (0, 1, 2).
The bug is that if you then go back to a single encoder instance,
either because you're doing singlecast or because you're doing
simulcast with scaling factors that are not power of two (not 4:2:1),
then the simulcast index which was previously set to 2 is not reset due
to the old code path never calling SetSimulcastIndex.
Example repro:
1. Send VP9 simulcast {180p, 360p, 720p}, i.e. 4:2.1.
2. Reconfigure to {180p, 360p, 540p}, i.e. no longer 4:2:1.
What should happen: all three layers are sent.
What actually happened: 180p is not sent and the 540p layer flips flops
between 180p and 540p because the EncodedImage says simulcast index is
2 for both encodings[0] and encodings[2].
The fix is a one-line change: `SetSimulcastIndex(std::nullopt)` in the
case that we don't have a `simulcast_to_svc_converter_` that sets it
(0, 1, 2) for us.
[1] https://webrtc-review.googlesource.com/c/src/+/360280
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| async_audio_processing | ||
| audio_coding | ||
| audio_device | ||
| audio_mixer | ||
| audio_processing | ||
| congestion_controller | ||
| desktop_capture | ||
| include | ||
| pacing | ||
| portal | ||
| remote_bitrate_estimator | ||
| rtp_rtcp | ||
| third_party | ||
| utility | ||
| video_capture | ||
| video_coding | ||
| BUILD.gn | ||
| module_common_types_unittest.cc | ||