mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
No description
28b793b4dd
As of [1], a single VP9 encoder instance can produce simulcast 4:2:1.
When it does, the EncodedImage has its simulcast index set (0, 1, 2).
The bug is that if you then go back to a single encoder instance,
either because you're doing singlecast or because you're doing
simulcast with scaling factors that are not power of two (not 4:2:1),
then the simulcast index which was previously set to 2 is not reset due
to the old code path never calling SetSimulcastIndex.
Example repro:
1. Send VP9 simulcast {180p, 360p, 720p}, i.e. 4:2.1.
2. Reconfigure to {180p, 360p, 540p}, i.e. no longer 4:2:1.
What should happen: all three layers are sent.
What actually happened: 180p is not sent and the 540p layer flips flops
between 180p and 540p because the EncodedImage says simulcast index is
2 for both encodings[0] and encodings[2].
The fix is a one-line change: `SetSimulcastIndex(std::nullopt)` in the
case that we don't have a `simulcast_to_svc_converter_` that sets it
(0, 1, 2) for us.
[1] https://webrtc-review.googlesource.com/c/src/+/360280
(cherry picked from commit
|
||
|---|---|---|
| api | ||
| audio | ||
| build_overrides | ||
| call | ||
| common_audio | ||
| common_video | ||
| data | ||
| docs | ||
| examples | ||
| experiments | ||
| g3doc | ||
| infra | ||
| logging | ||
| media | ||
| modules | ||
| net/dcsctp | ||
| p2p | ||
| pc | ||
| resources | ||
| rtc_base | ||
| rtc_tools | ||
| sdk | ||
| stats | ||
| system_wrappers | ||
| test | ||
| tools_webrtc | ||
| video | ||
| .clang-format | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .gn | ||
| .mailmap | ||
| .style.yapf | ||
| .vpython3 | ||
| AUTHORS | ||
| BUILD.gn | ||
| CODE_OF_CONDUCT.md | ||
| codereview.settings | ||
| DEPS | ||
| DIR_METADATA | ||
| ENG_REVIEW_OWNERS | ||
| LICENSE | ||
| license_template.txt | ||
| native-api.md | ||
| OWNERS | ||
| OWNERS_INFRA | ||
| PATENTS | ||
| PRESUBMIT.py | ||
| presubmit_test.py | ||
| presubmit_test_mocks.py | ||
| pylintrc | ||
| pylintrc_old_style | ||
| README.chromium | ||
| README.md | ||
| WATCHLISTS | ||
| webrtc.gni | ||
| webrtc_lib_link_test.cc | ||
| whitespace.txt | ||
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation