mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
webrtc/pc
History
Henrik Boström 28b793b4dd [Merge-130] Fix LibvpxVp9Encoder simulcast bug. 
As of [1], a single VP9 encoder instance can produce simulcast 4:2:1.
When it does, the EncodedImage has its simulcast index set (0, 1, 2).

The bug is that if you then go back to a single encoder instance,
either because you're doing singlecast or because you're doing
simulcast with scaling factors that are not power of two (not 4:2:1),
then the simulcast index which was previously set to 2 is not reset due
to the old code path never calling SetSimulcastIndex.

Example repro:
1. Send VP9 simulcast {180p, 360p, 720p}, i.e. 4:2.1.
2. Reconfigure to {180p, 360p, 540p}, i.e. no longer 4:2:1.

What should happen: all three layers are sent.
What actually happened: 180p is not sent and the 540p layer flips flops
between 180p and 540p because the EncodedImage says simulcast index is
2 for both encodings[0] and encodings[2].

The fix is a one-line change: `SetSimulcastIndex(std::nullopt)` in the
case that we don't have a `simulcast_to_svc_converter_` that sets it
(0, 1, 2) for us.

[1] https://webrtc-review.googlesource.com/c/src/+/360280

(cherry picked from commit a6fbb35ac1)

Bug: chromium:370299916
Change-Id: I94ce1a0bde43ef56cba930cb69b744877bbd4bf9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363941
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Original-Commit-Position: refs/heads/main@{#43109}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364302
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/branch-heads/6723@{#2}
Cr-Branched-From: 13e377b804f68aa9c20ea5e449666ea5248e3286-refs/heads/main@{#43019}
2024-10-01 10:25:48 +00:00
..
g3doc Document how bitrate probing works from a RTP perspective 2023-06-09 14:14:12 +00:00
scenario_tests Reland "Replace usage of link_capacity_kbps with DataRate link_capacity" 2024-05-16 10:39:10 +00:00
test Add WebRTC-MixedCodecSimulcast field trial 2024-09-04 08:45:44 +00:00
audio_rtp_receiver.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
audio_rtp_receiver.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
audio_rtp_receiver_unittest.cc Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
audio_track.cc Move rtc::make_ref_counted to api/ 2022-06-15 09:47:38 +00:00
audio_track.h Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
BUILD.gn Ensure <sys/socket.h> is included by using "rtc_base/net_helpers.h". 2024-09-10 14:23:24 +00:00
channel.cc Use PayloadTypePicker in WebRtcVoiceEngine 2024-09-09 18:44:21 +00:00
channel.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
channel_interface.h Remove all split channels related code 2023-06-29 09:32:04 +00:00
channel_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
connection_context.cc Split "helpers" from SSL target to "crypto_random" and rename 2024-06-07 06:41:51 +00:00
connection_context.h Deprecate rtc::RefCountInterface 2024-06-07 09:47:26 +00:00
data_channel_controller.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
data_channel_controller.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
data_channel_controller_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
data_channel_integrationtest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
data_channel_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
data_channel_utils.cc
data_channel_utils.h Format ^(api|call|common_audio|examples|media|net|p2p|pc)/ 2023-05-03 11:09:26 +00:00
DEPS Remove the SctpDataChannel::config_ member variable. 2023-03-12 17:28:14 +00:00
dtls_srtp_transport.cc Reduce logging verbosity of DTLS-SRTP RTCP transport 2023-08-22 13:48:09 +00:00
dtls_srtp_transport.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
dtls_srtp_transport_unittest.cc Convert signals in rtp_transport_internal.h to CallbackList 2023-09-05 11:37:32 +00:00
dtls_transport.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
dtls_transport.h Reduce locking in DtlsTransport 2023-12-14 21:01:04 +00:00
dtls_transport_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
dtmf_sender.cc Replace Thread::Invoke with Thread::BlockingCall 2022-09-09 10:44:17 +00:00
dtmf_sender.h Replace Thread::Invoke with Thread::BlockingCall 2022-09-09 10:44:17 +00:00
dtmf_sender_unittest.cc Remove sigslot usage from DtmfProviderInterface 2022-08-03 14:16:35 +00:00
external_hmac.cc
external_hmac.h Remove private SRTP include 2024-07-23 17:23:45 +00:00
ice_server_parsing.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
ice_server_parsing.h Reland "ice server parsing: return RTCError with more details" 2022-10-12 11:23:22 +00:00
ice_server_parsing_unittest.cc Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
ice_transport.cc
ice_transport.h Break out a few more targets from rtc_pc_base 2022-03-10 18:36:43 +00:00
ice_transport_unittest.cc Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
jitter_buffer_delay.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
jitter_buffer_delay.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
jitter_buffer_delay_unittest.cc Update IWYU tool with a mapping file 2022-02-24 11:05:06 +00:00
jsep_ice_candidate.cc Update IWYU tool with a mapping file 2022-02-24 11:05:06 +00:00
jsep_session_description.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
jsep_session_description_unittest.cc Split "helpers" from SSL target to "crypto_random" and rename 2024-06-07 06:41:51 +00:00
jsep_transport.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
jsep_transport.h Use PayloadTypePicker in WebRtcVoiceEngine 2024-09-09 18:44:21 +00:00
jsep_transport_collection.cc Reland "Add PT lookup function to JsepTransportController" 2024-08-26 17:24:15 +00:00
jsep_transport_collection.h Use SequenceChecker(SequenceChecker::kDetached) in a few places. 2023-03-24 07:44:18 +00:00
jsep_transport_controller.cc Use PayloadTypePicker in WebRtcVoiceEngine 2024-09-09 18:44:21 +00:00
jsep_transport_controller.h Use PayloadTypePicker in WebRtcVoiceEngine 2024-09-09 18:44:21 +00:00
jsep_transport_controller_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
jsep_transport_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
legacy_stats_collector.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
legacy_stats_collector.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
legacy_stats_collector_interface.h Delete api/stats_types.h in favor of api/legacy_stats_types.h 2022-11-14 12:10:06 +00:00
legacy_stats_collector_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
local_audio_source.cc Move rtc::make_ref_counted to api/ 2022-06-15 09:47:38 +00:00
local_audio_source.h
local_audio_source_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
media_factory.h Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies 2024-07-29 07:17:14 +00:00
media_protocol_names.cc Never pass a signed char to ctype macros like isdigit() 2022-05-30 13:05:03 +00:00
media_protocol_names.h Cleanup: Move some more protocol names into media_protocol_names 2021-11-02 11:51:31 +00:00
media_session.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
media_session.h Include-what-you-use pc/media_session 2024-05-08 15:07:53 +00:00
media_session_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
media_stream.cc Move rtc::make_ref_counted to api/ 2022-06-15 09:47:38 +00:00
media_stream.h Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument 2022-04-21 12:32:17 +00:00
media_stream_observer.cc Update pc/ to not use implicit conversion from scoped_refptr<T> to T*. 2022-04-20 13:18:33 +00:00
media_stream_observer.h Update pc/ to not use implicit conversion from scoped_refptr<T> to T*. 2022-04-20 13:18:33 +00:00
media_stream_proxy.h Change stream.AddTrack/RemoveTrack to take a scoped_refptr argument 2022-04-21 12:32:17 +00:00
media_stream_track_proxy.h Move VideoTrack's content_hint property to the signaling thread. 2022-02-15 21:55:59 +00:00
media_stream_unittest.cc Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
OWNERS Enforce policy that SDP munging requires special approval 2023-01-30 20:09:07 +00:00
peer_connection.cc Ensure <sys/socket.h> is included by using "rtc_base/net_helpers.h". 2024-09-10 14:23:24 +00:00
peer_connection.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_adaptation_integrationtest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_bundle_unittest.cc Move webrtc::AudioDeviceModule include to api/ folder 2024-04-22 08:56:31 +00:00
peer_connection_crypto_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_data_channel_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_encodings_integrationtest.cc [Merge-130] Fix LibvpxVp9Encoder simulcast bug. 2024-10-01 10:25:48 +00:00
peer_connection_end_to_end_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_factory.cc Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies 2024-07-29 07:17:14 +00:00
peer_connection_factory.h Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies 2024-07-29 07:17:14 +00:00
peer_connection_factory_proxy.h Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
peer_connection_factory_unittest.cc Move webrtc::AudioDeviceModule include to api/ folder 2024-04-22 08:56:31 +00:00
peer_connection_field_trial_tests.cc Remove DegradedCall - To be submitted after 2024-07-01 2024-08-30 08:08:39 +00:00
peer_connection_header_extension_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_histogram_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_ice_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_integrationtest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_interface_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_internal.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_jsep_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_media_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_message_handler.cc Rename api/stats_types.h to api/legacy_stats_types.h. 2022-11-11 10:29:25 +00:00
peer_connection_message_handler.h Rename api/stats_types.h to api/legacy_stats_types.h. 2022-11-11 10:29:25 +00:00
peer_connection_proxy.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_rampup_tests.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_rtp_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_signaling_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_simulcast_unittest.cc Remove more sstream deps 2024-07-09 10:30:26 +00:00
peer_connection_svc_integrationtest.cc Split "helpers" from SSL target to "crypto_random" and rename 2024-06-07 06:41:51 +00:00
peer_connection_wrapper.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
peer_connection_wrapper.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
proxy.h Apply include-cleaner to api direct files 2024-09-10 08:29:26 +00:00
proxy_unittest.cc Deprecate rtc::RefCountInterface 2024-06-07 09:47:26 +00:00
remote_audio_source.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
remote_audio_source.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtc_stats_collector.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtc_stats_collector.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtc_stats_collector_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtc_stats_integrationtest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtc_stats_traversal.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtc_stats_traversal.h
rtc_stats_traversal_unittest.cc Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
rtcp_mux_filter.cc
rtcp_mux_filter.h
rtcp_mux_filter_unittest.cc
rtp_media_utils.cc Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED 2021-11-15 21:44:59 +00:00
rtp_media_utils.h Remove <ostream> dependencies 2024-07-03 12:27:55 +00:00
rtp_media_utils_unittest.cc
rtp_parameters_conversion.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_parameters_conversion.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_parameters_conversion_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_receiver.cc Reland "Run IWYU on some files I intend to work on" 2024-06-05 08:59:49 +00:00
rtp_receiver.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_receiver_proxy.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_sender.cc Propagate environment to RtpSenders 2024-09-03 11:56:22 +00:00
rtp_sender.h Propagate environment to RtpSenders 2024-09-03 11:56:22 +00:00
rtp_sender_proxy.h Introduce the TransformerHost interface 2024-04-25 07:54:28 +00:00
rtp_sender_receiver_unittest.cc Propagate environment to RtpSenders 2024-09-03 11:56:22 +00:00
rtp_transceiver.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_transceiver.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_transceiver_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_transmission_manager.cc Propagate environment to RtpSenders 2024-09-03 11:56:22 +00:00
rtp_transmission_manager.h Propagate environment to RtpSenders 2024-09-03 11:56:22 +00:00
rtp_transport.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_transport.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_transport_internal.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
rtp_transport_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_data_channel.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_data_channel.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_transport.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_transport.h Change DataChannelInit::priority to integer and forward to SCTP transport 2024-07-30 15:07:25 +00:00
sctp_transport_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_utils.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_utils.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sctp_utils_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sdp_offer_answer.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sdp_offer_answer.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sdp_offer_answer_unittest.cc deflake rtcp-rsize test in TSAN 2024-05-27 12:51:11 +00:00
sdp_state_provider.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
sdp_utils.cc Update IWYU tool with a mapping file 2022-02-24 11:05:06 +00:00
sdp_utils.h
session_description.cc Format ^(api|call|common_audio|examples|media|net|p2p|pc)/ 2023-05-03 11:09:26 +00:00
session_description.h Remove code for supporting SDES 2024-02-08 14:34:04 +00:00
session_description_unittest.cc Update IWYU tool with a mapping file 2022-02-24 11:05:06 +00:00
simulcast_description.cc Introduce a variant of rtc::split that returns a vector of string_view 2022-01-25 08:25:50 +00:00
simulcast_description.h Introduce a variant of rtc::split that returns a vector of string_view 2022-01-25 08:25:50 +00:00
simulcast_sdp_serializer.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
simulcast_sdp_serializer.h Rename simulcast SDP serializer 2023-09-18 10:09:02 +00:00
simulcast_sdp_serializer_unittest.cc Rename simulcast SDP serializer 2023-09-18 10:09:02 +00:00
slow_peer_connection_integration_test.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
srtp_session.cc Remove SSRCs from libSRTP when removing them from the rtp_demuxer 2023-11-08 10:24:10 +00:00
srtp_session.h Remove SSRCs from libSRTP when removing them from the rtp_demuxer 2023-11-08 10:24:10 +00:00
srtp_session_unittest.cc srtp: demonstrate wraparound with loss decryption failure 2024-08-19 05:17:18 +00:00
srtp_transport.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
srtp_transport.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
srtp_transport_unittest.cc Reland "Clean up SRTP helper functions" 2024-07-08 15:33:47 +00:00
stream_collection.h Update pc/ to not use implicit conversion from scoped_refptr<T> to T*. 2022-04-20 13:18:33 +00:00
track_media_info_map.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
track_media_info_map.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
track_media_info_map_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
transceiver_list.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
transceiver_list.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
transport_stats.cc
transport_stats.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
usage_pattern.cc
usage_pattern.h
used_ids.h Dynamically assign ids to header extensions not enabled by default 2024-02-08 12:52:58 +00:00
used_ids_unittest.cc Dynamically assign ids to header extensions not enabled by default 2024-02-08 12:52:58 +00:00
video_rtp_receiver.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
video_rtp_receiver.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
video_rtp_receiver_unittest.cc Remove not-needed webrtc:: prefixes in pc/ 2023-11-13 13:23:04 +00:00
video_rtp_track_source.cc Use SequenceChecker(SequenceChecker::kDetached) in a few places. 2023-03-24 07:44:18 +00:00
video_rtp_track_source.h Use SequenceChecker(SequenceChecker::kDetached) in a few places. 2023-03-24 07:44:18 +00:00
video_rtp_track_source_unittest.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
video_track.cc Replace Thread::Invoke with Thread::BlockingCall 2022-09-09 10:44:17 +00:00
video_track.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
video_track_source.cc Use SequenceChecker(SequenceChecker::kDetached) in a few places. 2023-03-24 07:44:18 +00:00
video_track_source.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
video_track_source_proxy.cc Make RtpTransceiver not inherit from RefCountedObject. 2022-03-18 16:17:24 +00:00
video_track_source_proxy.h Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
video_track_unittest.cc Move rtc::make_ref_counted to api/ 2022-06-15 09:47:38 +00:00
webrtc_sdp.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
webrtc_sdp.h Break out parsing of FMTP lines so that others can use it 2024-05-16 10:22:23 +00:00
webrtc_sdp_unittest.cc Change cricket::Codec default id from 0 to -1 2024-09-12 21:26:48 +00:00
webrtc_session_description_factory.cc Migrate absl::optional to std::optional 2024-09-02 12:16:47 +00:00
webrtc_session_description_factory.h Remove code for supporting SDES 2024-02-08 14:34:04 +00:00