mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 15:47:53 +01:00
8481f6358e
As of recent changes, we can simply look at numberOfSimulcastStreams
because in the {active,inactive,inactive} case we get a single
webrtc::VideoStream here[1] which results in numberOfSimulcastStreams
being 1 here[2].
Looking at numberOfSimulcastStreams instead of using a helper is
preferred because it is more descriptive and in the future, when
{inactive,active,inactive} or {inactive,inactive,active} cases of VP9
simulcast is also supported (webrtc:15046) then this gating will work
even when the first layer is not the active one.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/video/config/encoder_stream_factory.cc;l=146;drc=c99753ac8f051e379ae68e281aaef04b0a5ca8f2
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/video_coding/video_codec_initializer.cc;l=77;drc=4baea5b07f2fd309892845cf2d1c0f4ca77862d3
# No need to wait for win chrome bot, everything else green
NOTRY=True
Bug: webrtc:15046
Change-Id: I8aaea2e8cc350bd01fb00cc7fd85032b7fdfe24d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299942
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39759}
|
||
|---|---|---|
| .. | ||
| test | ||
| av1_profile.cc | ||
| av1_profile.h | ||
| bitstream_parser.h | ||
| BUILD.gn | ||
| builtin_video_decoder_factory.cc | ||
| builtin_video_decoder_factory.h | ||
| builtin_video_encoder_factory.cc | ||
| builtin_video_encoder_factory.h | ||
| h264_profile_level_id.cc | ||
| h264_profile_level_id.h | ||
| OWNERS | ||
| scalability_mode.cc | ||
| scalability_mode.h | ||
| scalability_mode_helper.cc | ||
| scalability_mode_helper.h | ||
| sdp_video_format.cc | ||
| sdp_video_format.h | ||
| simulcast_stream.cc | ||
| simulcast_stream.h | ||
| spatial_layer.cc | ||
| spatial_layer.h | ||
| video_codec.cc | ||
| video_codec.h | ||
| video_decoder.cc | ||
| video_decoder.h | ||
| video_decoder_factory.h | ||
| video_decoder_factory_template.h | ||
| video_decoder_factory_template_dav1d_adapter.h | ||
| video_decoder_factory_template_libvpx_vp8_adapter.h | ||
| video_decoder_factory_template_libvpx_vp9_adapter.h | ||
| video_decoder_factory_template_open_h264_adapter.h | ||
| video_decoder_software_fallback_wrapper.cc | ||
| video_decoder_software_fallback_wrapper.h | ||
| video_encoder.cc | ||
| video_encoder.h | ||
| video_encoder_factory.h | ||
| video_encoder_factory_template.h | ||
| video_encoder_factory_template_libaom_av1_adapter.h | ||
| video_encoder_factory_template_libvpx_vp8_adapter.h | ||
| video_encoder_factory_template_libvpx_vp9_adapter.h | ||
| video_encoder_factory_template_open_h264_adapter.h | ||
| video_encoder_software_fallback_wrapper.cc | ||
| video_encoder_software_fallback_wrapper.h | ||
| vp8_frame_buffer_controller.h | ||
| vp8_frame_config.cc | ||
| vp8_frame_config.h | ||
| vp8_temporal_layers.cc | ||
| vp8_temporal_layers.h | ||
| vp8_temporal_layers_factory.cc | ||
| vp8_temporal_layers_factory.h | ||
| vp9_profile.cc | ||
| vp9_profile.h | ||