mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00
7f876c8930
The VP9 encoder may drop a frame internally which will not advance the frame pattern. Consider the following scenario where only spatial layer 0 and temporal layer 0 is active: 1. Key frame encoded 2. Spatial layer 1 is activated 3. Delta T0 dropped 4. Delta T0 encoded No S1T0 frame is encoded in (1) since it's not active. When NextFrameConfig is called in (3) it will say that future frames may reference T0 on both S0 and S1, but it's then dropped. On step (4), the SVC controller essentially thinks it's encoding a new picture and will happily reference the T0 on what it thinks is the first delta frame. However, this is actually still the key frame and since there was no S1T0 frame produced it will reference an invalid buffer. To fix this, only say it's possible to reference a T0 frame after it has been successfully encoded. Bug: webrtc:11999, webrtc:13142, chromium:1178444 Change-Id: Iab3d2042ce0b3fa7d952b2831d1a36b1a6613a86 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231695 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34982} |
||
|---|---|---|
| .. | ||
| BUILD.gn | ||
| create_scalability_structure.cc | ||
| create_scalability_structure.h | ||
| scalability_structure_full_svc.cc | ||
| scalability_structure_full_svc.h | ||
| scalability_structure_full_svc_unittest.cc | ||
| scalability_structure_key_svc.cc | ||
| scalability_structure_key_svc.h | ||
| scalability_structure_key_svc_unittest.cc | ||
| scalability_structure_l2t2_key_shift.cc | ||
| scalability_structure_l2t2_key_shift.h | ||
| scalability_structure_l2t2_key_shift_unittest.cc | ||
| scalability_structure_simulcast.cc | ||
| scalability_structure_simulcast.h | ||
| scalability_structure_test_helpers.cc | ||
| scalability_structure_test_helpers.h | ||
| scalability_structure_unittest.cc | ||
| scalable_video_controller.h | ||
| scalable_video_controller_no_layering.cc | ||
| scalable_video_controller_no_layering.h | ||
| svc_rate_allocator.cc | ||
| svc_rate_allocator.h | ||
| svc_rate_allocator_unittest.cc | ||